hauke/Magallanes
1
0
Fork 0
mirror of https://github.com/hauke68/Magallanes.git synced 2025-11-04 00:50:18 +01:00
Code Issues Releases Wiki Activity

SensioLabs Insight.

Browse Source
This commit is contained in:
Andrés Montañez 2015-02-21 14:23:24 -02:00
parent 00edf87862
commit dc18a91cf7
4 changed files with 26 additions and 37 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
Mage/Task/BuiltIn/Filesystem/PermissionsTask.php
View File

@ -159,7 +159,7 @@ class PermissionsTask extends AbstractTask
); );
foreach($options as $option => $apply) { foreach($options as $option => $apply) {
if ($apply == true) { if ($apply === true) {
$optionsForCmd .= $option; $optionsForCmd .= $option;
} }
} }
@ -192,7 +192,7 @@ class PermissionsTask extends AbstractTask
*/ */
protected function setPaths(array $paths) protected function setPaths(array $paths)
{ {
if ($this->checkPathsExist == true) { if ($this->checkPathsExist === true) {
$commands = array(); $commands = array();
foreach ($paths as $path) { foreach ($paths as $path) {
$commands[] = '(([ -f ' . $path . ' ]) || ([ -d ' . $path . ' ]))'; $commands[] = '(([ -f ' . $path . ' ]) || ([ -d ' . $path . ' ]))';
@ -241,8 +241,6 @@ class PermissionsTask extends AbstractTask
/** /**
* Set owner. * Set owner.
* *
* @todo check existance of $owner on host, might be different ways depending on OS.
*
* @param string $owner * @param string $owner
* @return PermissionsTask * @return PermissionsTask
*/ */
@ -264,8 +262,6 @@ class PermissionsTask extends AbstractTask
/** /**
* Set group. * Set group.
* *
* @todo check existance of $group on host, might be different ways depending on OS.
*
* @param string $group * @param string $group
* @return PermissionsTask * @return PermissionsTask
*/ */
@ -287,8 +283,6 @@ class PermissionsTask extends AbstractTask
/** /**
* Set rights. * Set rights.
* *
* @todo check if $rights is in a correct format.
*
* @param string $rights * @param string $rights
* @return PermissionsTask * @return PermissionsTask
*/ */

6
Mage/Task/BuiltIn/Ioncube/EncryptTask.php
View File

@ -33,7 +33,6 @@ use Mage\Task\ErrorWithMessageException;
* *
* Example enviroment.yaml file at end * Example enviroment.yaml file at end
* *
* @todo add support for creating license files.
* *
* (c) ActWeb 2013 * (c) ActWeb 2013
* (c) Matt Lowe (marl.scot.1@googlemail.com) * (c) Matt Lowe (marl.scot.1@googlemail.com)
@ -202,7 +201,7 @@ class EncryptTask extends AbstractTask
/* /*
* Get all our IonCube config options * Get all our IonCube config options
*/ */
$this->_getAllIonCubeConfigs(); $this->getAllIonCubeConfigs();
/* /*
* get the source code location * get the source code location
*/ */
@ -279,7 +278,7 @@ class EncryptTask extends AbstractTask
* *
* @return void * @return void
*/ */
private function _getAllIonCubeConfigs() private function getAllIonCubeConfigs()
{ {
/* /*
@ -553,7 +552,6 @@ class EncryptTask extends AbstractTask
* D - Default options as stored in script * D - Default options as stored in script
* *
* more options could be added to make this a bit more flexable * more options could be added to make this a bit more flexable
* @todo I'm sure this could be combined into a loop to make it easier and shorter
* *
*/ */
$s = array(); $s = array();

2
Mage/Task/BuiltIn/Releases/RollbackTask.php
View File

@ -59,8 +59,6 @@ class RollbackTask extends AbstractTask implements IsReleaseAware
$result = $this->runCommandRemote('ls -1 ' . $releasesDirectory, $output); $result = $this->runCommandRemote('ls -1 ' . $releasesDirectory, $output);
$releases = ($output == '') ? array() : explode(PHP_EOL, $output); $releases = ($output == '') ? array() : explode(PHP_EOL, $output);
$inDeploy = $this->getParameter('inDeploy',false);
if (count($releases) == 0) { if (count($releases) == 0) {
Console::output('Release are not available for <bold>' . $this->getConfig()->getHost() . '</bold> ... <red>FAIL</red>'); Console::output('Release are not available for <bold>' . $this->getConfig()->getHost() . '</bold> ... <red>FAIL</red>');

45
docs/example-config/.mage/tasks/SampleTaskRollbackAware.php
View File

@ -1,23 +1,22 @@
<?php <?php
namespace Task; namespace Task;
use Mage\Task\AbstractTask; use Mage\Task\AbstractTask;
use Mage\Task\Releases\RollbackAware; use Mage\Task\Releases\RollbackAware;
class SampleTaskRollbackAware extends AbstractTask implements RollbackAware class SampleTaskRollbackAware extends AbstractTask implements RollbackAware
{ {
public function getName() public function getName()
{ {
if ($this->inRollback()) { if ($this->inRollback()) {
return 'A Sample Task aware of rollbacks [in rollback]'; return 'A Sample Task aware of rollbacks [in rollback]';
} else { } else {
return 'A Sample Task aware of rollbacks [not in rollback]'; return 'A Sample Task aware of rollbacks [not in rollback]';
} }
} }
public function run() public function run()
{ {
return true; return true;
} }
} }