hauke/Magallanes
1
0
Fork 0
mirror of https://github.com/hauke68/Magallanes.git synced 2025-11-04 00:50:18 +01:00
Code Issues Releases Wiki Activity

minor phpdoc fix, test string fixed for unknown task class

Browse Source
This commit is contained in:
Claudio Zizza 2015-01-05 14:14:55 +01:00
parent 022b4282cd
commit 008383333a
2 changed files with 11 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
Mage/Task/Factory.php
View File

@ -30,7 +30,7 @@ class Factory
* @param boolean $inRollback
* @param string $stage
* @return \Mage\Task\AbstractTask
* @throws \Exception|\Mage\Task\ErrorWithMessageException
* @throws \Exception
*/
public static function get($taskData, Config $taskConfig, $inRollback = false, $stage = null)
{

11
tests/MageTest/Task/FactoryTest.php
View File

@ -30,6 +30,15 @@ class FactoryTest extends PHPUnit_Framework_TestCase
$this->assertInstanceOf('\\Mage\\Task\\AbstractTask', $task);
}
/**
* @dataProvider taskDataProvider
*/
public function testGetWith($taskData)
{
$task = Factory::get($taskData, $this->config);
$this->assertInstanceOf('\\Mage\\Task\\AbstractTask', $task);
}
/**
* @expectedException \Exception
* @expectedExceptionMessage The Task MyInconsistentTask must be an instance of Mage\Task\AbstractTask.
@ -45,7 +54,7 @@ class FactoryTest extends PHPUnit_Framework_TestCase
*/
public function testGetClassDoesNotExist()
{
Factory::get('notknowntask', $this->config);
Factory::get('unknowntask', $this->config);
}
/**